Skip to content

Add Search UI to config #3140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2024
Merged

Add Search UI to config #3140

merged 1 commit into from
Dec 10, 2024

Conversation

@colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Dec 9, 2024 •
edited
Loading

⚠️ Dependent on elastic/search-ui#1093

Adds a new Search UI book to the config. This is part of an effort to move the current Search UI docs to AsciiDoc. There is a bit of a 🐔 / 🥚 problem with this process:

  • This PR is dependent on a PR in elastic/search-ui that adds an AsciiDoc index file (Add inital AsciiDoc index page search-ui#1093).
  • This PR adds a stub Search UI book with just a single index page from the elastic/search-ui repo. This stub book will not be indexable by search engines.
  • After this PR is merged, I will open a PR in elastic/search-ui to add all the AsciiDoc content. That PR will include a preview that the docs and search teams can use to validate the AsciiDoc version of the Search UI docs.
  • After the elastic/search-ui PR is merged and the full Search UI book is live, I'll open another PR in this repo to remove noindex so the book will start being indexed by search engines.

@colleenmcginnis colleenmcginnis self-assigned this Dec 9, 2024
@github-actions
Copy link

github-actions bot commented Dec 9, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@colleenmcginnis colleenmcginnis mentioned this pull request Dec 9, 2024
Merged
@colleenmcginnis colleenmcginnis changed the title [not ready] Add Search UI to config Add Search UI to config Dec 10, 2024
@colleenmcginnis colleenmcginnis marked this pull request as ready for review December 10, 2024 15:45
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner December 10, 2024 15:45
@colleenmcginnis colleenmcginnis merged commit ca58278 into elastic:master Dec 10, 2024
5 checks passed
@colleenmcginnis colleenmcginnis deleted the add-search-ui branch December 10, 2024 15:57
This was referenced Dec 10, 2024
Merged
Merged
naemono pushed a commit to naemono/docs that referenced this pull request Dec 18, 2024
@colleenmcginnis @naemono
add search ui to config (elastic#3140)
cd4ebbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@Mpdreamz Mpdreamz Awaiting requested review from Mpdreamz Mpdreamz is a code owner automatically assigned from elastic/docs-repo-owners

@dedemorton dedemorton Awaiting requested review from dedemorton dedemorton is a code owner automatically assigned from elastic/docs-repo-owners

@kilfoyle kilfoyle Awaiting requested review from kilfoyle kilfoyle is a code owner automatically assigned from elastic/docs-repo-owners

Assignees

@colleenmcginnis colleenmcginnis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@colleenmcginnis @bmorelli25